This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Adding WinRM extension #3485
Merged
Adding WinRM extension #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3485 +/- ##
==========================================
+ Coverage 55.94% 55.94% +<.01%
==========================================
Files 105 105
Lines 15917 15888 -29
==========================================
- Hits 8905 8889 -16
+ Misses 6262 6253 -9
+ Partials 750 746 -4 |
|
@jsturtevant - what do you think? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3460 for dev investigations. I'm making it an optional extension at first so I can do more tests on robustness and get some feedback on this from a security standpoint before it's enabled by default.
Using this extension will enable Windows Remote Management using HTTPS with a self-signed certificate. That's enough to enable some basic remote management from the commandline and enable tools like https://github.com/patricklang/logslurp to gather logs into a central place for troubleshooting.