This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
fix(cni-networking): Enables br_netfilter kernel module
#3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this module, iptables rules to not apply to bridges.
|
cc @jessfraz |
|
ah jeez good find lgtm |
jackfrancis
reviewed
Jul 17, 2018
| @@ -257,6 +257,11 @@ function installCNI() { | |||
| tar -xzf $CONTAINERNETWORKING_CNI_TGZ_TMP -C $CNI_BIN_DIR | |||
| chown -R root:root $CNI_BIN_DIR | |||
| chmod -R 755 $CNI_BIN_DIR | |||
| # Turn on br_netfilter (needed for the iptables rules to work on bridges) | |||
| # and permanently enable it | |||
| modprobe br_netfilter | |||
There was a problem hiding this comment.
Let's do retrycmd_if_failure 10 5 10 modprobe br_netfilter above to appease the runtime provisioning gods.
Codecov Report
@@ Coverage Diff @@
## master #3484 +/- ##
=======================================
Coverage 55.94% 55.94%
=======================================
Files 105 105
Lines 15917 15917
=======================================
Hits 8905 8905
Misses 6262 6262
Partials 750 750 |
jackfrancis
approved these changes
Jul 17, 2018
jackfrancis
pushed a commit
that referenced
this pull request
Jul 17, 2018
Without this module, iptables rules to not apply to bridges.
kkmsft
pushed a commit
to kkmsft/acs-engine
that referenced
this pull request
Jul 20, 2018
Without this module, iptables rules to not apply to bridges.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:'
Without this module, iptables rules do not apply to bridges and network overlays do not function
Release note: