Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Do not enable AcceleratedNetworkingEnabled by default on upgrade #3483

Merged

Conversation

CecileRobertMichon
Copy link
Contributor

What this PR does / why we need it: Follow up for #3449 which broke back compat upgrade: only enable Accelerated Networking on create.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@ghost ghost added the in progress label Jul 16, 2018
CecileRobertMichon added 2 commits July 16, 2018 16:58
@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #3483 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3483   +/-   ##
=======================================
  Coverage   55.94%   55.94%           
=======================================
  Files         105      105           
  Lines       15917    15917           
=======================================
  Hits         8905     8905           
  Misses       6262     6262           
  Partials      750      750

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit fd97afd into Azure:master Jul 17, 2018
@ghost ghost removed the in progress label Jul 17, 2018
kkmsft pushed a commit to kkmsft/acs-engine that referenced this pull request Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants