This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Unit tests and minor code cleanup for GetTenantID. #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
force-pushed
the
get_tenantid_test
branch
from
7d803c5 to
6c2355a
Compare
tariq1890
commented
Jul 12, 2018
| "github.com/pkg/errors" | ||
| log "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| // GetTenantID figures out the AAD tenant ID of the subscription by making an | ||
| // unauthenticated request to the Get Subscription Details endpoint and parses | ||
| // the value from WWW-Authenticate header. | ||
| func GetTenantID(env azure.Environment, subscriptionID string) (string, error) { | ||
| func GetTenantID(resourceManagerEndpoint string, subscriptionID string) (string, error) { |
There was a problem hiding this comment.
With this change, we are able to do away with an unnecessary import :)
Codecov Report
@@ Coverage Diff @@
## master #3467 +/- ##
==========================================
+ Coverage 55.83% 55.93% +0.09%
==========================================
Files 105 105
Lines 15884 15883 -1
==========================================
+ Hits 8869 8884 +15
+ Misses 6270 6253 -17
- Partials 745 746 +1 |
julienstroheker
pushed a commit
to julienstroheker/acs-engine
that referenced
this pull request
Jul 16, 2018
kkmsft
pushed a commit
to kkmsft/acs-engine
that referenced
this pull request
Jul 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Trying out net/http/test for writing unit tests for GetTenantID
Special notes for your reviewer:
If applicable:
Release note: