Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Pass ARM_CLOUD to autoscaler #3446

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

gsacavdm
Copy link
Contributor

@gsacavdm gsacavdm commented Jul 8, 2018

What this PR does / why we need it: Pass the Azure cloud name to the cluster autoscaler via the ARM_CLOUD environment variable.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3445

Special notes for your reviewer: None.

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Add support for national clouds in cluster-autoscaler 

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @sozercan PTAL

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #3446 into master will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master    #3446      +/-   ##
==========================================
- Coverage   55.85%   55.83%   -0.02%     
==========================================
  Files         105      105              
  Lines       15878    15884       +6     
==========================================
+ Hits         8868     8869       +1     
- Misses       6265     6270       +5     
  Partials      745      745

@CecileRobertMichon CecileRobertMichon merged commit 455b4e8 into Azure:master Jul 11, 2018
@gsacavdm gsacavdm deleted the autoscaler-cloud branch July 11, 2018 20:56
julienstroheker pushed a commit to julienstroheker/acs-engine that referenced this pull request Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM_CLOUD is not passed down to autoscaler
3 participants