Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Adding test for and fixing daemonsets that should not run on Windows #3407

Merged
merged 2 commits into from
Jul 4, 2018

Conversation

PatrickLang
Copy link
Contributor

Will help prevent problems such as #3404

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

@ghost ghost assigned PatrickLang Jul 3, 2018
@ghost ghost added the in progress label Jul 3, 2018
@acs-bot acs-bot added the size/S label Jul 3, 2018
@PatrickLang
Copy link
Contributor Author

/hold

Will be adding the fix for #3404 but I want to see the new test fail first.

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #3407 into master will decrease coverage by 0.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3407      +/-   ##
==========================================
- Coverage   55.37%   54.51%   -0.87%     
==========================================
  Files         104      104              
  Lines       15785    15787       +2     
==========================================
- Hits         8741     8606     -135     
- Misses       6325     6429     +104     
- Partials      719      752      +33

@PatrickLang
Copy link
Contributor Author

Alright, we're failing as expected:

------------------------------
Azure Container Cluster using the Kubernetes Orchestrator with a windows agent pool 
  Should not have any unready or crashing pods right after deployment
  /go/src/github.com/Azure/acs-engine/test/e2e/kubernetes/kubernetes_test.go:780
STEP: Checking ready status of each pod in kube-system

$ kubectl get pods -n kube-system -o json
2018/07/03 22:24:50 Checking azure-cni-networkmonitor-t9g2r
2018/07/03 22:24:50 Checking azure-cni-networkmonitor-tg2wr

• Failure [0.623 seconds]
Azure Container Cluster using the Kubernetes Orchestrator
/go/src/github.com/Azure/acs-engine/test/e2e/kubernetes/kubernetes_test.go:58
  with a windows agent pool
  /go/src/github.com/Azure/acs-engine/test/e2e/kubernetes/kubernetes_test.go:740
    Should not have any unready or crashing pods right after deployment [It]
    /go/src/github.com/Azure/acs-engine/test/e2e/kubernetes/kubernetes_test.go:780

    Expected
        <bool>: false
    to be true

    /go/src/github.com/Azure/acs-engine/test/e2e/kubernetes/kubernetes_test.go:788
------------------------------

@PatrickLang PatrickLang force-pushed the plang-failedwinpodtest branch from d317f1d to 0cd2fff Compare July 3, 2018 22:34
@PatrickLang
Copy link
Contributor Author

Squashed and ready for review. The test case would fail on master - see the previous comment above. This should pass the new tests.

/hold cancel

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Jul 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, PatrickLang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants