-
Notifications
You must be signed in to change notification settings - Fork 558
Adding test for and fixing daemonsets that should not run on Windows #3407
Conversation
/hold Will be adding the fix for #3404 but I want to see the new test fail first. |
Codecov Report
@@ Coverage Diff @@
## master #3407 +/- ##
==========================================
- Coverage 55.37% 54.51% -0.87%
==========================================
Files 104 104
Lines 15785 15787 +2
==========================================
- Hits 8741 8606 -135
- Misses 6325 6429 +104
- Partials 719 752 +33 |
Alright, we're failing as expected:
|
Will help prevent problems such as Azure#3404
d317f1d
to
0cd2fff
Compare
Squashed and ready for review. The test case would fail on master - see the previous comment above. This should pass the new tests. /hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, PatrickLang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will help prevent problems such as #3404
If applicable: