Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Use errgroup instead of counting goroutines #3387

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Jun 29, 2018

What this PR does / why we need it:
Use errgroup instead of counting goroutines for syncing multiple goroutines.
This is much safer for future modification.

This is much safer for future modification.
@jackfrancis
Copy link
Member

/lgtm pending E2E thanks @cpuguy83!

@acs-bot
Copy link

acs-bot commented Jul 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpuguy83, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #3387 into master will decrease coverage by 0.06%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master    #3387      +/-   ##
==========================================
- Coverage   54.59%   54.52%   -0.07%     
==========================================
  Files         104      104              
  Lines       15778    15750      -28     
==========================================
- Hits         8614     8588      -26     
+ Misses       6412     6411       -1     
+ Partials      752      751       -1

@jackfrancis jackfrancis merged commit 40cda4d into Azure:master Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants