This repository was archived by the owner on Jan 11, 2023. It is now read-only.
fix(addons): Adds missing cluster subnet substitution for flannel #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flannel configmap was using a hardcoded value for the cluster subnet, so when you used a custom one, it would not route traffic properly
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thomastaylor312 Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jessfraz FYI This lgtm, thanks @thomastaylor312! |
|
nice thanks :) |
jackfrancis
approved these changes
Jun 25, 2018
Codecov Report
@@ Coverage Diff @@
## master #3356 +/- ##
=======================================
Coverage 52.99% 52.99%
=======================================
Files 104 104
Lines 15689 15689
=======================================
Hits 8314 8314
Misses 6633 6633
Partials 742 742 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The flannel configmap was using a hardcoded value for the cluster subnet, so when you used a custom one, it would not route traffic properly