Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Fix OMS addon + add tests and documentation for addons #3342

Merged
merged 10 commits into from
Jun 25, 2018

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Jun 22, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3254

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #3342 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3342   +/-   ##
=======================================
  Coverage   53.01%   53.01%           
=======================================
  Files         104      104           
  Lines       15683    15683           
=======================================
  Hits         8314     8314           
  Misses       6627     6627           
  Partials      742      742

CecileRobertMichon added 2 commits June 22, 2018 11:06
@CecileRobertMichon CecileRobertMichon changed the title Add tests and documentation for addons Fix OMS addon + add tests and documentation for addons Jun 22, 2018
CecileRobertMichon added 2 commits June 22, 2018 14:00
@acs-bot acs-bot added size/L and removed size/M labels Jun 22, 2018
@CecileRobertMichon
Copy link
Contributor Author

@rashmichandrashekar FYI

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit c70ce4a into Azure:master Jun 25, 2018
@ghost ghost removed the in progress label Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing addon docs
3 participants