This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Mount audit log file to disk #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kichristensen Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @CecileRobertMichon |
|
@CecileRobertMichon what do you think about this? |
Codecov Report
@@ Coverage Diff @@
## master #3335 +/- ##
======================================
Coverage 53% 53%
======================================
Files 104 104
Lines 15682 15682
======================================
Hits 8313 8313
Misses 6627 6627
Partials 742 742 |
julienstroheker
pushed a commit
to julienstroheker/acs-engine
that referenced
this pull request
Jul 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Audit logging in enabled by default in Kubernetes 1.8 and above, but you cannot get to the log file easy, because it is only accessible within the kube-apiserver container. This PR puts the file on the host instead.
Special notes for your reviewer:
The path of the audit log is changed, because I don't think it will be a good idea to mount the hosts
/var/logto the container.If applicable:
Release note: