Enabling 2 Windows E2E tests #3332
Conversation
ghost
assigned 
|
/assign @jackfrancis |
|
If it passes this could replace #3241 |
Codecov Report
@@ Coverage Diff @@
## master #3332 +/- ##
==========================================
- Coverage 53% 52.46% -0.55%
==========================================
Files 104 103 -1
Lines 15682 15472 -210
==========================================
- Hits 8313 8118 -195
+ Misses 6627 6624 -3
+ Partials 742 730 -12 |
|
/retest ? |
|
@jackfrancis can you kick this tomorrow? This seems like a flake unrelated to my last change |
|
/retest |
|
I'm kicking failed tests through CircleCI UI. k8s-linux-default-e2e passed now |
test/e2e/kubernetes/util/util.go
Outdated
| ) | ||
|
|
||
| // PrintCommand prints a command string | ||
| func PrintCommand(cmd *exec.Cmd) { | ||
| fmt.Printf("\n$ %s\n", strings.Join(cmd.Args, " ")) | ||
| } | ||
|
|
||
| // RunAndLogCommand logs the command with a timestamp when it's run, and duration at and | ||
| func RunAndLogCommand(cmd *exec.Cmd) ([]byte, error) { |
There was a problem hiding this comment.
@jackfrancis @CecileRobertMichon are you ok with this tiny refactor as part of this PR? If not I can split it into a separate PR
There was a problem hiding this comment.
before
STEP: Creating a nginx deployment
$ kubectl run ingress-nginx-kubernetes-eastus-5726-17635 -n default --image library/nginx:latest --overrides { "apiVersion": "extensions/v1beta1", "spec":{"template":{"spec": {"nodeSelector":{"beta.kubernetes.io/os":"linux"}}}}} --labels=app=ingress-nginx
after
STEP: Creating a nginx deployment
2018/06/22 16:38:14 $ kubectl run nginx-kubernetes-eastus-67793-62845 -n default --image library/nginx:latest --overrides { "apiVersion": "extensions/v1beta1", "spec":{"template":{"spec": {"nodeSelector":{"beta.kubernetes.io/os":"linux"}}}}}
2018/06/22 16:38:14 #### $ kubectl run nginx-kubernetes-eastus-67793-62845 -n default --image library/nginx:latest --overrides { "apiVersion": "extensions/v1beta1", "spec":{"template":{"spec": {"nodeSelector":{"beta.kubernetes.io/os":"linux"}}}}} completed in 286.941082ms
There was a problem hiding this comment.
Fine with me but I think there's a typo at the end of the comment
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, PatrickLang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| ) | ||
|
|
||
| // PrintCommand prints a command string | ||
| func PrintCommand(cmd *exec.Cmd) { | ||
| fmt.Printf("\n$ %s\n", strings.Join(cmd.Args, " ")) | ||
| } | ||
|
|
||
| // RunAndLogCommand logs the command with a timestamp when it's run, and the duration at end |
There was a problem hiding this comment.
Thanks @CecileRobertMichon - fixed typo
What this PR does / why we need it:
I'm relying on the automated tests for this, so there may be another commit or two added before it's ready to merge.
Special notes for your reviewer:
If applicable: