Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Remove dependency on ci in codecov yaml #3316

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Jun 20, 2018

What this PR does / why we need it: This PR will allow codecov to post about coverage even if CI fails. However, ci needs to run before codecov results are sent out (https://docs.codecov.io/docs/ci-service-relationship#section-checking-ci-status, https://docs.codecov.io/v4.3.6/docs/merging-reports#section-delayed-notifications)

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

Merging #3316 into master will increase coverage by 0.3%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #3316     +/-   ##
=========================================
+ Coverage      53%   53.31%   +0.3%     
=========================================
  Files         104      104             
  Lines       15682    15574    -108     
=========================================
- Hits         8313     8304      -9     
+ Misses       6627     6537     -90     
+ Partials      742      733      -9

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 5e08e6a into Azure:master Jun 20, 2018
@ghost ghost removed the in progress label Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants