Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Fix for kubelet startup script when using azure cni #3301

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

madhanrm
Copy link
Contributor

@madhanrm madhanrm commented Jun 19, 2018

What this PR does / why we need it:
For 1803 & below, to workaround a known issue, we need the network to be recreated on reboot. This PR adds that workaround into the Kubeletstartup script.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
As soon as the fix for the original issue is serviced (probably in June Servicing), we can remove this for 1803. But may still need it for 1709.

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@acs-bot acs-bot added the size/S label Jun 19, 2018
@saiyan86
Copy link
Contributor

@madhanrm Hi Madhan, could you please add some descriptions to this PR? Thanks!

@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #3301 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3301      +/-   ##
==========================================
- Coverage    52.9%   52.87%   -0.04%     
==========================================
  Files         104      104              
  Lines       15716    15714       -2     
==========================================
- Hits         8315     8308       -7     
- Misses       6668     6671       +3     
- Partials      733      735       +2

@madhanrm
Copy link
Contributor Author

@saiyan86 Have updated the description.

@madhanrm
Copy link
Contributor Author

@saiyan86 can you get this PR approved.

@saiyan86
Copy link
Contributor

/assign @jackfrancis

@saiyan86
Copy link
Contributor

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 22, 2018

@saiyan86: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saiyan86
Copy link
Contributor

@madhanrm Thanks for updating. I just approved the PR.

@jackfrancis
Copy link
Member

/lgtm pending E2E

@acs-bot
Copy link

acs-bot commented Jun 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, madhanrm, saiyan86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit ec39e30 into Azure:master Jun 25, 2018
@madhanrm madhanrm deleted the l2tunnelfix branch August 6, 2018 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants