Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

More unit tests #3300

Merged
merged 4 commits into from
Jun 20, 2018
Merged

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Jun 19, 2018

What this PR does / why we need it: Add some unit tests for ssh functions to increase coverage.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@CecileRobertMichon CecileRobertMichon changed the title [WIP] More unit tests More unit tests Jun 19, 2018
"github.com/Azure/acs-engine/pkg/i18n"
)

func TestCreateSSH(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved this down to the right test file

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 0579e60 into Azure:master Jun 20, 2018
@ghost ghost removed the in progress label Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants