Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Fix instance metadata + vmss default behavior for k8s 1.10.0 to 1.10.2 #3275

Merged

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Jun 14, 2018

What this PR does / why we need it: Instance metadata + VMSS + k8s version < 1.10.2 doesn't work. So far there was validation to ensure that a user explicitly specifies AvailabilitySet or instance meta data = false with k8s 1.10.0 and 1.10.1. This PR makes it easier by assigning the default according to those rules. New default behavior is:

  • k8s version < 1.10.0: AvailabilitySet, useInstanceMetadata: true

  • k8s version == 1.10.0 or 1.10.1: AvailabilitySet, useInstanceMetadata: true, unless useInstanceMetadata is set to false, then VMSS is default

  • k8s version >= 1.10.2: VMSS, useInstanceMetadata: true

To summarize, useInstanceMetadata is always set to true by default if the value is empty. The availabilityProfile depends on whether VMSS is supported with the other options.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@acs-bot acs-bot added size/S and removed size/XS labels Jun 14, 2018
@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Jun 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 0f2a6dd into Azure:master Jun 15, 2018
@ghost ghost removed the in progress label Jun 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants