Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Adding keyvaultSecretRef usage information to cluster definition docs #3250

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

bnookala
Copy link
Contributor

What this PR does / why we need it:

Adds keyvaultSecretRef usage docs to cluster definition.

Which issue this PR fixes:

None

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@acs-bot
Copy link

acs-bot commented Jun 12, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bnookala
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jackfrancis

Assign the PR to them by writing /assign @jackfrancis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bnookala
Copy link
Contributor Author

/assign @jackfrancis

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @bnookala !

@CecileRobertMichon CecileRobertMichon merged commit d75e4f7 into Azure:master Jun 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants