Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Fix missing flags in staticWindowsAPIServerConfig #3239

Closed
wants to merge 1 commit into from

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Jun 8, 2018

What this PR does / why we need it:

Bug fix to ensure hybrid clusters with windows agent nodes get all the static apiserver configs.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fixes #3219

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis
Copy link
Member

/approve
/lgtm

@acs-bot
Copy link

acs-bot commented Jun 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Member

Thank you @ritazh! This PR reminds us that we shouldn't be doing anything at all Windows-specific for control plane componetry. See #3240

@jackfrancis jackfrancis closed this Jun 8, 2018
@ghost ghost removed the in progress label Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

staticWindowsAPIServerConfig is missing some flags
4 participants