This repository was archived by the owner on Jan 11, 2023. It is now read-only.
DCOS: added tags to VMs in cluster #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
yakman2020
approved these changes
Jun 8, 2018
radhikaj
reviewed
Jun 8, 2018
| @@ -26,6 +26,7 @@ | |||
| {{end}} | |||
| ], | |||
| {{end}} | |||
| "orchestratorVersion": "{{.OrchestratorProfile.OrchestratorVersion}}", | |||
There was a problem hiding this comment.
Here in agentWindowsVersion can we tag with whether it is a Windows or a Linux agent?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmitsh, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3232 +/- ##
==========================================
- Coverage 52.37% 52.37% -0.01%
==========================================
Files 103 103
Lines 15430 15429 -1
==========================================
- Hits 8082 8081 -1
Misses 6621 6621
Partials 727 727 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCOS: added tags to VMs in cluster