Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

fix #3190 only use nvidia-container-runtime on gpu nodes #3192

Closed
wants to merge 1 commit into from

Conversation

johnhofman
Copy link

What this PR does / why we need it:
Allows deployment of a cluster with cpu and gpu agent pools with the nvidia-device-plugin enabled. Without this the docker daemon on the cpu nodes fails to start.

Which issue this PR fixes *
This fixes #3190 by only making the changes to /etc/docker/daemon.json on gpu enabled nodes using the same template switch which enables/disables the installation of the GPU drivers.

@acs-bot
Copy link

acs-bot commented Jun 6, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jackfrancis

Assign the PR to them by writing /assign @jackfrancis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot added the size/XS label Jun 6, 2018
@sozercan
Copy link
Member

sozercan commented Jun 6, 2018

Thanks @johnhofman!

#3181 also addresses this issue and adds toleration for device plugin so it doesn't get scheduled on CPU nodes. I'll close this in favor of #3181 unless you see anything else missing?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hybrid clusters with GPU & CPU do not work
3 participants