This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Make vendor semver package #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
CecileRobertMichon
force-pushed
the
re-vendor-semver
branch
from
6946766 to
dc54b0a
Compare
CecileRobertMichon
force-pushed
the
re-vendor-semver
branch
from
dc54b0a to
e644a9f
Compare
replace Masterminds/semver by blang/semver update vendor replace semver in validate fix bug in LT and GT functions fix prelease UT fix false unit test expectations remove hardcoded test fix lint
CecileRobertMichon
force-pushed
the
re-vendor-semver
branch
from
e644a9f to
45f14bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #3184 +/- ##
==========================================
+ Coverage 52.31% 52.36% +0.05%
==========================================
Files 103 103
Lines 15458 15426 -32
==========================================
- Hits 8087 8078 -9
+ Misses 6643 6621 -22
+ Partials 728 727 -1 |
CecileRobertMichon
force-pushed
the
re-vendor-semver
branch
from
45f14bd to
cbac3f4
Compare
CecileRobertMichon
force-pushed
the
re-vendor-semver
branch
from
1287892 to
9479f8f
Compare
Closed
3 tasks
jackfrancis
reviewed
Jun 7, 2018
pkg/api/types.go
Outdated
| @@ -859,8 +859,8 @@ func (o *OrchestratorProfile) GetAPIServerEtcdAPIVersion() string { | |||
| ret := "etcd3" | |||
There was a problem hiding this comment.
Let's change this entire function to:
etcdversion, _ := semver.Make(o.KubernetesConfig.EtcdVersion)
return "etcd" + etcdversion.Major
jackfrancis
reviewed
Jun 7, 2018
pkg/api/vlabs/validate.go
Outdated
| @@ -149,17 +149,15 @@ func (o *OrchestratorProfile) Validate(isUpdate, HasWindows bool) error { | |||
| return err | |||
| } | |||
| minVersion := "1.7.0" | |||
| cons, _ := semver.Make(minVersion) | |||
There was a problem hiding this comment.
Change these two lines to:
minVersion, _ := semver.Make("1.7.0")
There was a problem hiding this comment.
And then use minVersion below in place of cons
There was a problem hiding this comment.
Also return errors when it's practical
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The Masterminds semver package has a bug when comparing pre-release versions, use github.com/blang/semver instead.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: