This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
check for kubernetesConfig nil #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3164 +/- ##
========================================
+ Coverage 51.79% 51.9% +0.1%
========================================
Files 102 102
Lines 15230 15235 +5
========================================
+ Hits 7889 7908 +19
+ Misses 6615 6598 -17
- Partials 726 729 +3 |
|
@ultimateboy PTAL |
jackfrancis
added a commit
that referenced
this pull request
Jun 5, 2018
lachie83
added a commit
to lachie83/acs-engine
that referenced
this pull request
Jun 5, 2018
This reverts commit c5594e7.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: need to accommodate execution flows with a nil
KubernetesConfigin theirOrchestratorProfile.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: