This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Get kubeconfig in e2e as early as possible #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #3152 +/- ##
==========================================
+ Coverage 51.82% 51.87% +0.04%
==========================================
Files 102 102
Lines 15222 15199 -23
==========================================
- Hits 7889 7884 -5
+ Misses 6607 6591 -16
+ Partials 726 724 -2 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provisioning of a cluster may fail for various reasons and we will never set the kubeconfig resulting in failing to retrieve cluster info. With this change we set the kubeconfig in the e2e config struct as soon as we have it (ie. after
acs-engine generateruns).@CecileRobertMichon @jackfrancis @jim-minter ptal