Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Updating the go-bindata go get paths #3119

Merged
merged 1 commit into from
May 31, 2018
Merged

Conversation

tariq1890
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #3119 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3119      +/-   ##
==========================================
- Coverage   51.89%   51.82%   -0.07%     
==========================================
  Files          99       99              
  Lines       15160    15041     -119     
==========================================
- Hits         7867     7795      -72     
+ Misses       6571     6533      -38     
+ Partials      722      713       -9
Impacted Files Coverage Δ
pkg/api/types.go 32.88% <0%> (-6.2%) ⬇️
pkg/api/vlabs/validate.go 49.44% <0%> (-0.8%) ⬇️
pkg/api/vlabs/types.go 21.42% <0%> (-0.65%) ⬇️
pkg/acsengine/engine.go 63.16% <0%> (-0.03%) ⬇️
pkg/acsengine/addons.go 100% <0%> (ø) ⬆️
pkg/acsengine/k8s_versions.go 100% <0%> (ø) ⬆️
pkg/api/converterfromapi.go 9.67% <0%> (+0.06%) ⬆️
pkg/acsengine/defaults.go 83.67% <0%> (+0.19%) ⬆️
pkg/api/convertertoapi.go 55.86% <0%> (+0.33%) ⬆️
pkg/acsengine/defaults-kubelet.go 93.9% <0%> (+3.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497e012...39f7d41. Read the comment docs.

@jackfrancis
Copy link
Member

/approve
/lgtm

@jackfrancis
Copy link
Member

/approve
/lgtm

@acs-bot
Copy link

acs-bot commented May 31, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit ec9ee24 into Azure:master May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants