This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix k8s 1.11.0-alpha.2+ cluster bootstrap issue #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm, I cherry-picked this, solves my issue. |
Codecov Report
@@ Coverage Diff @@
## master #3117 +/- ##
=======================================
Coverage 51.82% 51.82%
=======================================
Files 99 99
Lines 15041 15041
=======================================
Hits 7795 7795
Misses 6533 6533
Partials 713 713Continue to review full report at Codecov.
|
|
Thank you @karataliu! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix systemd service quote issue.
New validation was introduced in kubelet that does not allow empty argument, but using empty variable ${} in systemd will interpret as empty argument. This is to address the issue.
Reference:
kubernetes/kubernetes#61833
https://unix.stackexchange.com/questions/175461/how-to-use-quote-and-dollarsign-with-systemd
Fixes #3098
Related #2838
cc @jackfrancis @CecileRobertMichon