Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Add doc for useManagedIdentity #3097

Merged
merged 2 commits into from
May 29, 2018
Merged

Add doc for useManagedIdentity #3097

merged 2 commits into from
May 29, 2018

Conversation

richerlariviere
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes:
fixes #3075

Special notes for your reviewer:
This is my first contribution to acs-engine. I hope I got the contributing guidelines right :P.

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

@acs-bot acs-bot added the size/M label May 28, 2018
@msftclas
Copy link

msftclas commented May 28, 2018

CLA assistant check
All CLA requirements met.

@richerlariviere richerlariviere changed the title Doc add usemanagedidentity Add doc for usemanagedidentity May 28, 2018
@richerlariviere richerlariviere changed the title Add doc for usemanagedidentity Add doc for UseManagedIdentity May 28, 2018
@richerlariviere richerlariviere changed the title Add doc for UseManagedIdentity Add doc for useManagedIdentity May 28, 2018
@richerlariviere
Copy link
Contributor Author

/assign @brendandburns
/cc @CecileRobertMichon

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@acs-bot
Copy link

acs-bot commented May 29, 2018

@CecileRobertMichon: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@acs-bot
Copy link

acs-bot commented May 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

|networkPlugin|no|Specifies the network plugin implementation for the cluster. Valid values are:<br>`"azure"` (default), which provides an Azure native networking experience <br>`"kubenet"` for k8s software networking implementation. <br> `"flannel"` for using CoreOS Flannel <br> `"cilium"` for using the default Cilium CNI IPAM |
|networkPolicy|no|Specifies the network policy enforcement tool for the cluster (currently Linux-only). Valid values are:<br>`calico` for Calico network policy.<br>`cilium` for cilium network policy (Lin).<br>See [network policy examples](../examples/networkpolicy) for more information|
|containerRuntime|no|The container runtime to use as a backend. The default is `docker`. The other options are `clear-containers` and `containerd`|
|addons|no|Configure various Kubernetes addons configuration (currently supported: tiller, kubernetes-dashboard). See `addons` configuration below|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reordering 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem :) I think the rest of the file could be rearranged as well (I could do it later) but for now I just wanted to focus on the issue.

@CecileRobertMichon CecileRobertMichon merged commit d966110 into Azure:master May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useManagedIdentity not in documentation
5 participants