Rationalize AvailabilityProfile default #3065
Conversation
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3065 +/- ##
==========================================
+ Coverage 51.49% 51.53% +0.04%
==========================================
Files 99 99
Lines 15026 15017 -9
==========================================
+ Hits 7737 7739 +2
+ Misses 6582 6572 -10
+ Partials 707 706 -1
Continue to review full report at Codecov.
|
|
@sozercan could you please take a look at this PR? |
| } | ||
|
|
||
| // validation for instanceMetadata using VMSS on Kubernetes | ||
| if a.OrchestratorProfile.OrchestratorType == Kubernetes && (agentPoolProfile.AvailabilityProfile == VirtualMachineScaleSets || len(agentPoolProfile.AvailabilityProfile) == 0) { |
There was a problem hiding this comment.
This validation was duplicated
CecileRobertMichon
added
awaiting review
ready
and removed
needs manual validation
awaiting review
labels
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: We were setting AvailabilityProfile to VMSS by default. However, VMSS is not supported for K8s < 1.10. This PR ensures that we set AvailabilityProfile to AvailabilitySet if using K8s < 1.10.
Backwards compatibility should not be affected because we were validating before to make sure that VMSS was not set with k8s < 1.10. This change just makes it easier for the user by setting a default that works with validation instead of requiring an override.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: