Revert vmss extension name #3059
Conversation
ghost
assigned 
.circleci/config.yml
Outdated
| @@ -135,7 +135,7 @@ jobs: | |||
| - checkout | |||
| - run: | | |||
| echo 'export TIMEOUT=10m' >> $BASH_ENV | |||
| echo 'export CLUSTER_DEFINITION=examples/kubernetes.json' >> $BASH_ENV | |||
| echo 'export CLUSTER_DEFINITION=examples/kubernetes-vmss/kubernetes.json' >> $BASH_ENV | |||
There was a problem hiding this comment.
VMSS is the default so updating the "k8s Linux default" to use vmss since all the other e2e tests use AvailabilitySet
There was a problem hiding this comment.
Instead of this, let's just update the examples/kubernetes.json api model to no longer specify an "availabilityProfile" (it should use vmss by default)
Codecov Report
@@ Coverage Diff @@
## master #3059 +/- ##
=======================================
Coverage 51.49% 51.49%
=======================================
Files 99 99
Lines 15026 15026
=======================================
Hits 7737 7737
Misses 6582 6582
Partials 707 707Continue to review full report at Codecov.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: PR #3031 changed the CSE name for vmss agents. This broke vmss deployments because vmss agentpools do not have a variable "offset".
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #3064Special notes for your reviewer:
If applicable:
Release note: