Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

added instuctions for installation with gofish #3055

Merged
merged 1 commit into from
May 23, 2018
Merged

added instuctions for installation with gofish #3055

merged 1 commit into from
May 23, 2018

Conversation

maniSbindra
Copy link
Contributor

What this PR does / why we need it: To Fix issue 2624

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2624

Special notes for your reviewer: Tested installing on MAC and Windows

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@ghost ghost assigned maniSbindra May 23, 2018
@ghost ghost added the in progress label May 23, 2018
@jackfrancis
Copy link
Member

/approve
/lgtm

@bacongobbler just as a sanity check!

@acs-bot
Copy link

acs-bot commented May 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I will note that I still need to update the acs-engine fish food to 0.17.0. I'll see about doing that tonight unless someone beats me to it :)

@jackfrancis jackfrancis merged commit ff3b5d4 into Azure:master May 23, 2018
@ghost ghost removed the in progress label May 23, 2018
@jackfrancis
Copy link
Member

Thanks @maniSbindra!

@bacongobbler
Copy link
Contributor

If anyone wants to tackle it, here's what's involved (just 4 lines of code): fishworks/fish-food#24

@bacongobbler
Copy link
Contributor

Just following up here: fishworks/fish-food#40

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add acs-engine install with fish instructions
4 participants