-
Notifications
You must be signed in to change notification settings - Fork 558
Version artifacts gathering in openshift e2e #3053
Conversation
WIP until I actually test with 3.10 |
/label orchestrator/openshift |
Codecov Report
@@ Coverage Diff @@
## master #3053 +/- ##
=======================================
Coverage 51.89% 51.89%
=======================================
Files 99 99
Lines 15160 15160
=======================================
Hits 7867 7867
Misses 6571 6571
Partials 722 722 |
/assign jim-minter |
/cc pweil- |
openshift test flaked on the etcd timeout issue |
/approve |
The code coverage context being red blocks tide from merging this PR fyi @CecileRobertMichon @jackfrancis |
@Kargakis I can change codecov config to not block below a certain threshold, it hasn't been a problem up to now since code coverage wasn't a required status check. |
Yeah, please do
…On Wed, May 30, 2018 at 11:55 PM, Cecile Robert-Michon < ***@***.***> wrote:
@Kargakis <https://github.com/kargakis> I can change codecov config to
not block below a certain threshold, it hasn't been a problem up to now
since code coverage wasn't a required status check.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3053 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADuFf09_pp21KfUrKVmGloPx-hny5rceks5t3xVKgaJpZM4UKqdp>
.
|
New changes are detected. LGTM label has been removed. |
Rebased, I will babysit this PR until it gets merged, thanks! |
docs failure:
restarting |
k8s-windows-1.8-release-e2e failure:
restarting |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This probably needs a github approval on top of the github labels in order to get automatically merged (seems github approvals are required to enable merging PRs in this repo). |
This isn't auto-merging because of tide cert errors, merging now. |
Builds on top of #2996
@jim-minter @mjudeikis @kwoodson @pweil-