Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Version artifacts gathering in openshift e2e #3053

Merged
merged 2 commits into from
Jun 1, 2018
Merged

Version artifacts gathering in openshift e2e #3053

merged 2 commits into from
Jun 1, 2018

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented May 23, 2018

@acs-bot acs-bot added the size/L label May 23, 2018
@0xmichalis 0xmichalis changed the title Version artifacts gathering in openshift e2e [WIP] Version artifacts gathering in openshift e2e May 23, 2018
@0xmichalis
Copy link
Contributor Author

WIP until I actually test with 3.10

@0xmichalis
Copy link
Contributor Author

/label orchestrator/openshift

@codecov
Copy link

codecov bot commented May 26, 2018

Codecov Report

Merging #3053 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3053   +/-   ##
=======================================
  Coverage   51.89%   51.89%           
=======================================
  Files          99       99           
  Lines       15160    15160           
=======================================
  Hits         7867     7867           
  Misses       6571     6571           
  Partials      722      722

@ghost ghost assigned 0xmichalis May 30, 2018
@ghost ghost added the in progress label May 30, 2018
@0xmichalis
Copy link
Contributor Author

/assign jim-minter

@0xmichalis
Copy link
Contributor Author

/cc pweil-

@acs-bot acs-bot requested a review from pweil- May 30, 2018 02:46
@0xmichalis 0xmichalis changed the title [WIP] Version artifacts gathering in openshift e2e Version artifacts gathering in openshift e2e May 30, 2018
@0xmichalis
Copy link
Contributor Author

openshift test flaked on the etcd timeout issue

@jackfrancis
Copy link
Member

/approve
/lgtm

@0xmichalis
Copy link
Contributor Author

The code coverage context being red blocks tide from merging this PR fyi @CecileRobertMichon @jackfrancis

@CecileRobertMichon
Copy link
Contributor

@Kargakis I can change codecov config to not block below a certain threshold, it hasn't been a problem up to now since code coverage wasn't a required status check.

@0xmichalis
Copy link
Contributor Author

0xmichalis commented May 30, 2018 via email

@CecileRobertMichon
Copy link
Contributor

@Kargakis #3115 is merged, if you rebase we can try getting acs-bot to merge this one (otherwise if I can just merge it manually, let me know)

@acs-bot
Copy link

acs-bot commented May 31, 2018

New changes are detected. LGTM label has been removed.

@acs-bot acs-bot removed the lgtm label May 31, 2018
@0xmichalis
Copy link
Contributor Author

Rebased, I will babysit this PR until it gets merged, thanks!

@0xmichalis
Copy link
Contributor Author

docs failure:

$ az group deployment create --name dcos-southeastasia-63351 --resource-group dcos-southeastasia-63351 --template-file /go/src/github.com/Azure/acs-engine/_output/dcos-southeastasia-63351/azuredeploy.json --parameters /go/src/github.com/Azure/acs-engine/_output/dcos-southeastasia-63351/azuredeploy.parameters.json
...............
$ timeout 60 az vm list -g dcos-southeastasia-63351

2018/05/31 17:29:08 SSH Key: /go/src/github.com/Azure/acs-engine/_output/dcos-southeastasia-63351-ssh
2018/05/31 17:29:08 Master Node: azureuser@dcos-southeastasia-63351.southeastasia.cloudapp.azure.com
2018/05/31 17:29:08 SSH Command: ssh -i /go/src/github.com/Azure/acs-engine/_output/dcos-southeastasia-63351-ssh -p 2200 azureuser@dcos-southeastasia-63351.southeastasia.cloudapp.azure.com
2018/05/31 17:29:13 Error while trying dcos cluster setup:Process exited with status 1
2018/05/31 17:29:13 Output:URL [http://localhost:80/pkgpanda/active.buildinfo.full.json] is unreachable.

2018/05/31 17:29:13 Circle?:true
2018/05/31 17:29:13 Jenkins?:false
2018/05/31 17:29:13 Point:test,branch=pull/3053,build_number=29314,ci=circleci,commit-sha=e98bd1405c3b456787ccb2e66114f49b5203934f,definition=examples/dcos.json,job=dcos-e2e,location=southeastasia,orchestrator=dcos,subscription_id=5684bae7-6a09-47a6-bdf1-695d1fd8ac1f node-wait-error-count=1,node-wait-secs=5.135910503,provision-error-count=0,provision-secs=915.512304025,test-error-count=0,test-secs=0,total-secs=920.651160986 1527787753413285965
2018/05/31 17:29:13 Deleting Group:dcos-southeastasia-63351

$ timeout 60 az group delete --name dcos-southeastasia-63351 --no-wait --yes
2018/05/31 17:29:18 Error while trying to provision cluster:Error trying to install dcos client:Process exited with status 1
exit status 1
test.mk:29: recipe for target 'test-dcos' failed
make: *** [test-dcos] Error 1
Exited with code 2

restarting

@CecileRobertMichon
Copy link
Contributor

@Kargakis the DCOS test has been flaky lately #3080, apologies for the inconvenience. We might want to reopen that issue.

@0xmichalis
Copy link
Contributor Author

k8s-windows-1.8-release-e2e failure:

$ az group deployment create --name kubernetes-southcentralus-54245 --resource-group kubernetes-southcentralus-54245 --template-file /go/src/github.com/Azure/acs-engine/_output/kubernetes-southcentralus-54245/azuredeploy.json --parameters /go/src/github.com/Azure/acs-engine/_output/kubernetes-southcentralus-54245/azuredeploy.parameters.json
.............................................................2018/05/31 17:55:20 
Error from deployment for kubernetes-southcentralus-54245 in resource group kubernetes-southcentralus-54245:exit status 1
2018/05/31 17:55:20 Command Output: ERROR: Deployment failed. Correlation ID: 6cd045a0-828d-4f50-b899-15001f175c99. {

  "status": "Failed",

  "error": {

    "code": "ResourceDeploymentFailure",

    "message": "The resource operation completed with terminal provisioning state 'Failed'.",

    "details": [

      {

        "code": "OSProvisioningTimedOut",

        "message": "OS Provisioning for VM '38681k8s9000' did not finish in the allotted time. The VM may still finish provisioning successfully. Please check provisioning state later."

      }

    ]

  }

}

restarting

@jackfrancis
Copy link
Member

/lgtm

@jackfrancis
Copy link
Member

/approve

@acs-bot
Copy link

acs-bot commented May 31, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@0xmichalis
Copy link
Contributor Author

This probably needs a github approval on top of the github labels in order to get automatically merged (seems github approvals are required to enable merging PRs in this repo).

@CecileRobertMichon
Copy link
Contributor

This isn't auto-merging because of tide cert errors, merging now.

@CecileRobertMichon CecileRobertMichon merged commit 1d3b08c into Azure:master Jun 1, 2018
@ghost ghost removed the in progress label Jun 1, 2018
@0xmichalis 0xmichalis deleted the logs-39 branch June 1, 2018 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants