Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

DCOS: implement upgrade operation for clusters with bootstrap node #3030

Merged
merged 3 commits into from
May 22, 2018

Conversation

dmitsh
Copy link

@dmitsh dmitsh commented May 21, 2018

implement upgrade operation for clusters with bootstrap node

@ghost ghost assigned dmitsh May 21, 2018
@ghost ghost added the in progress label May 21, 2018
@codecov
Copy link

codecov bot commented May 21, 2018

Codecov Report

Merging #3030 into master will decrease coverage by 0.78%.
The diff coverage is 32.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3030      +/-   ##
=========================================
- Coverage   51.59%   50.8%   -0.79%     
=========================================
  Files          97      99       +2     
  Lines       14834   14980     +146     
=========================================
- Hits         7654    7611      -43     
- Misses       6482    6672     +190     
+ Partials      698     697       -1
Impacted Files Coverage Δ
cmd/scale.go 0% <0%> (-12.93%) ⬇️
cmd/root.go 25.39% <0%> (+10.88%) ⬆️
pkg/operations/remote_ssh.go 0% <0%> (ø)
cmd/dcos-upgrade.go 32.5% <32.5%> (ø)
pkg/api/orchestrators.go 68.26% <57.14%> (+0.01%) ⬆️
cmd/orchestrators.go 31.81% <0%> (-45.46%) ⬇️
cmd/deploy.go 24.46% <0%> (-18.02%) ⬇️
cmd/generate.go 32.38% <0%> (-15.24%) ⬇️
pkg/operations/kubernetesupgrade/upgrader.go 57.56% <0%> (-0.47%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3482257...7b43834. Read the comment docs.

@jackfrancis
Copy link
Member

Running upgrade sanity check, will merge after

@jackfrancis
Copy link
Member

/approve
/lgtm

@acs-bot
Copy link

acs-bot commented May 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 5e49cf1 into Azure:master May 22, 2018
@ghost ghost removed the in progress label May 22, 2018
@dmitsh dmitsh deleted the ds-upgrade-dcos branch June 8, 2018 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants