Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Fix prometheus extension due to renaming cse #3018

Merged
merged 1 commit into from
May 21, 2018

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented May 19, 2018

What this PR does / why we need it:
Update prometheus extension with new cse naming convention
Tested this extension on both master and agent

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Fixes #2926

FYI @trstringer

@ritazh ritazh requested a review from CecileRobertMichon May 19, 2018 05:05
@acs-bot
Copy link

acs-bot commented May 19, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cecilerobertmichon

Assign the PR to them by writing /assign @cecilerobertmichon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ghost ghost assigned ritazh May 19, 2018
@ghost ghost added the in progress label May 19, 2018
@acs-bot acs-bot added the size/S label May 19, 2018
@trstringer
Copy link
Contributor

Looks good to me! Thanks, @ritazh! 👍 😄

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CecileRobertMichon CecileRobertMichon merged commit ad6de63 into Azure:master May 21, 2018
@ghost ghost removed the in progress label May 21, 2018
@ghost
Copy link

ghost commented May 21, 2018

@CecileRobertMichon @ritazh Do we think this should resolve the issues with extensions in VMSS as well? Or was there anything specific to VMSS still that will prevent extensions from working?

@CecileRobertMichon
Copy link
Contributor

@neurot1cal I think VMSS might be a separate problem. I'm working on a PR to fix it.

@ritazh
Copy link
Member Author

ritazh commented May 21, 2018

@neurot1cal The VMSS issue is a separate issue as described here: Azure/vm-scale-sets#26 We will keep you posted as soon as that fix is released by the VMSS team.

@CecileRobertMichon
Copy link
Contributor

Yes @ritazh is correct there are two separate issues, the timeout one won't be addressed by my PR, only the naming incompatibility. PR opened at #3031.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions not working
4 participants