This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@PatrickLang can you sanity-check this change to not install heapster addon on Windows nodes? |
Codecov Report
@@ Coverage Diff @@
## master #3002 +/- ##
=======================================
Coverage 50.74% 50.74%
=======================================
Files 97 97
Lines 14689 14689
=======================================
Hits 7454 7454
Misses 6536 6536
Partials 699 699 Continue to review full report at Codecov.
|
code LGTM. Will try a deployment shortly |
/LGTM after testing. It scheduled it on a Linux agent node as expected
|
PatrickLang
approved these changes
May 18, 2018
PatrickLang
approved these changes
May 18, 2018
back to you @jackfrancis |
jackfrancis
approved these changes
May 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you @adelina-t and @PatrickLang!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3001