Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add node selector for heapster addon #3002

Merged
merged 1 commit into from
May 18, 2018

Conversation

adelina-t
Copy link
Contributor

Fixes #3001

@jackfrancis
Copy link
Member

@PatrickLang can you sanity-check this change to not install heapster addon on Windows nodes?

@codecov
Copy link

codecov bot commented May 17, 2018

Codecov Report

Merging #3002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3002   +/-   ##
=======================================
  Coverage   50.74%   50.74%           
=======================================
  Files          97       97           
  Lines       14689    14689           
=======================================
  Hits         7454     7454           
  Misses       6536     6536           
  Partials      699      699

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388f58f...8e60627. Read the comment docs.

@PatrickLang
Copy link
Contributor

code LGTM. Will try a deployment shortly

@PatrickLang
Copy link
Contributor

PatrickLang commented May 18, 2018

/LGTM

after testing. It scheduled it on a Linux agent node as expected

$ kubectl get node -o wide
NAME                       STATUS    ROLES     AGE       VERSION   EXTERNAL-IP   OS-IMAGE                    KERNEL-VERSION   CONTAINER-RUNTIME
37007k8s9000               Ready     <none>    6m        v1.10.1   <none>        Windows Server Datacenter   10.0.17134.1
                           docker://17.6.2
37007k8s9001               Ready     <none>    5m        v1.10.1   <none>    Windows Server Datacenter   10.0.17134.1
                           docker://17.6.2
k8s-linuxpool-37007586-0   Ready     agent     6m        v1.10.1   <none>    Ubuntu 16.04.4 LTS   4.13.0-1016-azure   docker://1.13.1
k8s-linuxpool-37007586-1   Ready     agent     5m        v1.10.1   <none>    Ubuntu 16.04.4 LTS   4.13.0-1016-azure   docker://1.13.1
k8s-master-37007586-0      Ready     master    9m        v1.10.1   <none>    Ubuntu 16.04.4 LTS   4.13.0-1016-azure   docker://1.13.1

$ kubectl -n kube-system get pod -o wide
NAME                                            READY     STATUS    RESTARTS   AGE       IP             NODE
heapster-6f7b9bdf-b764b                         2/2       Running   0          8m        10.240.0.141   k8s-linuxpool-37007586-0
kube-addon-manager-k8s-master-37007586-0        1/1       Running   0          7m        10.255.255.5   k8s-master-37007586-0
kube-apiserver-k8s-master-37007586-0            1/1       Running   0          8m        10.255.255.5   k8s-master-37007586-0
kube-controller-manager-k8s-master-37007586-0   1/1       Running   0          8m        10.255.255.5   k8s-master-37007586-0
kube-dns-v20-59b4f7dc55-5rdnd                   3/3       Running   0          8m        10.240.0.129   k8s-linuxpool-37007586-0
kube-dns-v20-59b4f7dc55-w7csn                   3/3       Running   0          8m        10.240.0.138   k8s-linuxpool-37007586-0
kube-proxy-bqwmz                                1/1       Running   0          6m        10.240.0.127   k8s-linuxpool-37007586-0
kube-proxy-fgjtm                                1/1       Running   0          8m        10.255.255.5   k8s-master-37007586-0
kube-proxy-sx8gd                                1/1       Running   0          6m        10.240.0.4     k8s-linuxpool-37007586-1
kube-scheduler-k8s-master-37007586-0            1/1       Running   0          8m        10.255.255.5   k8s-master-37007586-0
kubernetes-dashboard-65c8bbc84b-m85wd           1/1       Running   0          8m        10.240.0.149   k8s-linuxpool-37007586-0
metrics-server-5c74cf6d4f-qvhwd                 1/1       Running   0          8m        10.240.0.9     k8s-linuxpool-37007586-1
tiller-deploy-d85ccb55c-gfdlb                   1/1       Running   0          8m        10.240.0.13    k8s-linuxpool-37007586-1
Node-Selectors:  beta.kubernetes.io/os=linux
Tolerations:     CriticalAddonsOnly
Events:
  Type     Reason                 Age              From                               Message
  ----     ------                 ----             ----                               -------
  Warning  FailedScheduling       5m (x9 over 7m)  default-scheduler                  0/1 nodes are available: 1 node(s) had taints that the pod didn't tolerate.
  Warning  FailedScheduling       4m (x5 over 5m)  default-scheduler                  0/2 nodes are available: 1 node(s) didn't match node selector, 1 node(s) had taints that the pod didn't tolerate.
  Normal   Scheduled              4m               default-scheduler                  Successfully assigned heapster-6f7b9bdf-b764b to k8s-linuxpool-37007586-0

@PatrickLang
Copy link
Contributor

back to you @jackfrancis

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @adelina-t and @PatrickLang!

@jackfrancis jackfrancis merged commit 3b87ba4 into Azure:master May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants