This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Update docs for Azure CNI subnet requirements #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned | @@ -733,10 +733,8 @@ func setAgentNetworkDefaults(a *api.Properties) { | |||
|
|
|||
| // Allocate IP addresses for pods if VNET integration is enabled. | |||
| if a.OrchestratorProfile.IsAzureCNI() { | |||
| if a.OrchestratorProfile.OrchestratorType == api.Kubernetes { | |||
There was a problem hiding this comment.
This was redundant because IsAzureCNI() returns false if a.OrchestratorProfile.OrchestratorType != api.Kubernetes
| @@ -9,7 +9,7 @@ | |||
| "jumpboxProfile": { | |||
| "name": "my-jb", | |||
| "vmSize": "Standard_D2_v2", | |||
| "diskSizeGB": 30, | |||
There was a problem hiding this comment.
This was a typo
| @@ -9,7 +9,7 @@ | |||
| "jumpboxProfile": { | |||
| "name": "my-jb", | |||
| "vmSize": "Standard_D2_v2", | |||
| "diskSizeGB": 30, | |||
jackfrancis
reviewed
May 16, 2018
docs/kubernetes/features.md
Outdated
| @@ -204,7 +204,7 @@ you can define stricter policies. Good resources to get information about that a | |||
|
|
|||
| *Note: Custom VNET for Kubernetes Windows cluster has a [known issue](https://github.com/Azure/acs-engine/issues/1767).* | |||
|
|
|||
| ACS Engine supports deploying into an existing VNET. Operators must specify the ARM path/id of Subnets for the `masterProfile` and any `agentPoolProfiles`, as well as the first IP address to use for IP static IP allocation in `firstConsecutiveStaticIP`. Additionally, to prevent source address NAT'ing within the VNET, we assign to the `vnetCidr` property in `masterProfile` the CIDR block that represents the usable address space in the existing VNET. | |||
| ACS Engine supports deploying into an existing VNET. Operators must specify the ARM path/id of Subnets for the `masterProfile` and any `agentPoolProfiles`, as well as the first IP address to use for static IP allocation in `firstConsecutiveStaticIP`. Please note that in any azure subnet, the first four and the last ip address is reserved and can not be used. Additionally, each POD now gets the IP address from the Subnet. As a result, enough IP addresses (equal to `ipAddressCount` for each node) should be available beyond `firstConsecutiveStaticIP`. By default, the `ipAddressCount` has a value of 31, 1 for the node and 30 for pods, (note that the number of pods can be changed via `KubeletConfig["--max-pods"]`). `ipAddressCount` can be changed if desired. Furthermore, to prevent source address NAT'ing within the VNET, we assign to the `vnetCidr` property in `masterProfile` the CIDR block that represents the usable address space in the existing VNET. | |||
There was a problem hiding this comment.
unless you meant https://www.pods.com
There was a problem hiding this comment.
oh yeah thanks, not what I meant... I'll fix it
CecileRobertMichon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2992 +/- ##
==========================================
+ Coverage 50.75% 50.77% +0.02%
==========================================
Files 97 97
Lines 14682 14691 +9
==========================================
+ Hits 7452 7460 +8
- Misses 6533 6534 +1
Partials 697 697
Continue to review full report at Codecov.
|
CecileRobertMichon
changed the title
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Improves documentation for subnet reserved IPs with Azure CNI (specifically, Azure CNI reserves 1 IP + as many IPs as the max-pod value of that node for each node). TODO: add validation to prevent deployment if subnet is too small.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2897Special notes for your reviewer:
If applicable:
Release note: