-
Notifications
You must be signed in to change notification settings - Fork 558
Build kubletwin/pause to match the node's OS version #2976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'm deploying a cluster with this, will report test results. |
Codecov Report
@@ Coverage Diff @@
## master #2976 +/- ##
=======================================
Coverage 50.78% 50.78%
=======================================
Files 97 97
Lines 14692 14692
=======================================
Hits 7461 7461
Misses 6534 6534
Partials 697 697 Continue to review full report at Codecov.
|
be4cc96
to
9152d6b
Compare
Hmm, the single quote literals in my PowerShell scripts were breaking things. Switched to double quote, squashed, and rewrote history. Deployment is in progress |
Alright - good news, it built |
Deployed https://gist.githubusercontent.com/PatrickLang/2cf4b81c9518e531b828a71e4c430332/raw/f6a209a0282e0baf123084aa848965cd332985c9/whoami-1803.yaml and it ran!
|
Marathon failed to install in DCOS, and I can't decypher the error in openshift. Neither of those paths can reach this code from my understanding. How should we proceed? @jackfrancis |
Success on 1709
|
@PatrickLang how did you deploy 1709 now since 1803 supercedes it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@JiangtianLi - to make sure I was hitting 1709 or 1803, I set the windowsSku:
or
|
@PatrickLang I see, windows profile has the option to choose windows sku and 1803 is the default. |
What this PR does / why we need it:
This container is built before each windows agent is added to the cluster. The OS of the container needs to match that of the windows agent. Without this change, it's hardcoded. With this change, it will match the host OS version (Windows Server 2016, Windows Server version 1709, Windows Server version 1803, or Windows Server Insider Preview)
Which issue this PR fixes
#2965
Special notes for your reviewer:
I could use some guidance testing this. Can I just build acs-engine as-is, or do I need to do some other steps to ensure this change is picked up?
If applicable:
Will need to test on both Windows Server version 1709, and 1803 to make sure the
kubletwin/pause
image is build correctly and that pods can start successfully.Release note: