Remove docker #2973

jessfraz · 2018-05-15T20:37:52Z

This pull request makes it so when the container runtime is set to containerd or clear-containers docker is never installed.

cc @thomastaylor312

Just some clean up after part one in #2967

jessfraz · 2018-05-15T21:11:58Z

here is clear-containers running with that https://jenkins.azure-containers.io/view/acs-engine/job/k8s-clear-containers/117/console

codecov · 2018-05-18T19:18:43Z

Codecov Report

Merging #2973 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2973      +/-   ##
==========================================
- Coverage   53.01%   52.99%   -0.03%     
==========================================
  Files         104      104              
  Lines       15683    15689       +6     
==========================================
  Hits         8314     8314              
- Misses       6627     6633       +6     
  Partials      742      742

jackfrancis · 2018-05-18T19:19:05Z

FYI rebased/force-pushed to accommodate recent changes to CSE in master

jackfrancis · 2018-05-18T19:20:27Z

parts/k8s/kubernetescustomscript.sh

@@ -339,8 +339,22 @@ function ensureKubelet() {
 }

 function extractHyperkube(){
-    retrycmd_if_failure 100 1 60 docker pull $HYPERKUBE_URL || $ERR_K8S_DOWNLOAD_TIMEOUT
-    systemctlEnableAndStart hyperkube-extract
+    TMP_DIR=$(mktemp -d)


@jessfraz is TMP_DIR used anywhere?

jackfrancis · 2018-05-18T19:29:47Z

test/e2e/runner/cli_provisioner.go

@@ -242,7 +242,7 @@ func (cli *CLIProvisioner) FetchProvisioningMetrics(path string, cfg *config.Con
 	agentFiles := []string{"/var/log/azure/cluster-provision.log", "/var/log/cloud-init.log",
 		"/var/log/cloud-init-output.log", "/var/log/syslog", "/var/log/azure/custom-script/handler.log",
 		"/opt/m", "/opt/azure/containers/kubelet.sh", "/opt/azure/containers/provision.sh",
-		"/opt/azure/provision-ps.log", "/var/log/azure/kubelet-status.log", "/var/log/azure/hyperkube-extract-status.log",


Thanks for the love here!

jackfrancis · 2018-05-18T19:43:13Z

@jessfraz img pull command is erroring w/ the following:

creating worker opt failed: cannot find runc binary locally, please install runc

dividinglimits · 2018-05-19T00:37:25Z

pkg/api/types.go

@@ -737,6 +737,11 @@ func (a *AgentPoolProfile) HasDisks() bool {
 	return len(a.DiskSizesGB) > 0
 }

+// RequiresDocker returns if the kubernetes settings require docker to be installed.
+func (a *AgentPoolProfile) RequiresDocker() bool {
+	return a.KubernetesConfig.ContainerRuntime == "docker"


Please forgive my ignorance, but since these are exported, is it guaranteed that this value will always be lower case during its initialization?

jessfraz · 2018-05-21T21:18:14Z

ah I tested on the one with containerd, will update

jessfraz · 2018-05-21T23:51:16Z

Running:
https://jenkins.azure-containers.io/view/acs-engine/job/k8s-containerd/3/
https://jenkins.azure-containers.io/view/acs-engine/job/k8s-clear-containers/128/
https://jenkins.azure-containers.io/view/acs-engine/job/k8s-network-flannel/7/
https://jenkins.azure-containers.io/view/acs-engine/job/k8s-network-cilium/90

jessfraz · 2018-05-22T17:58:40Z

looks like dns is failing randomly in the tests is this usual? I am wondering how this might have broken that

jackfrancis · 2018-05-22T18:15:56Z

@jessfraz it's testing pod name resolution. What do you see if you build a cluster from this branch and try to resolve DNS from within a pod?

jessfraz · 2018-06-12T17:42:37Z

Passed: https://jenkins.azure-containers.io/view/acs-engine/job/k8s-containerd/28/console

jackfrancis · 2018-06-12T17:45:09Z

Thanks @jessfraz! @CecileRobertMichon or I can help with the rebase, as the CSE implementation is a sensitive surface area constantly undergoing refinements :)

jessfraz · 2018-06-12T17:45:51Z

oh im rebasing

…

On Tue, Jun 12, 2018 at 1:45 PM Jack Francis ***@***.***> wrote: Thanks @jessfraz <https://github.com/jessfraz>! @CecileRobertMichon <https://github.com/CecileRobertMichon> or I can help with the rebase, as the CSE implementation is a sensitive surface area constantly undergoing refinements :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2973 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYNbC6EN1LL4qyLBI62LKGFp1fSqo_3ks5t7_4sgaJpZM4UAO7Z> .

-- Jessie Frazelle 4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3 pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>

jackfrancis · 2018-06-15T20:01:24Z

FYI rebased, gonna see if we can nudge this into working order

jackfrancis · 2018-06-15T20:18:22Z

@jessfraz Just built a v1.8.13 cluster and am able to repro E2E failures. Specifically, resolving external DNS from a pod:

azureuser@k8s-master-25395533-0:~$ kubectl logs validate-dns-hj5br -c validate-bing
Server:    10.0.0.10
Address 1: 10.0.0.10

nslookup: can't resolve 'www.bing.com'
waiting for DNS resolution
nslookup: can't resolve 'www.bing.com'
Server:    10.0.0.10
Address 1: 10.0.0.10

waiting for DNS resolution
azureuser@k8s-master-25395533-0:~$ kubectl logs validate-dns-hj5br -c validate-google
Server:    10.0.0.10
Address 1: 10.0.0.10

waiting for DNS resolution
nslookup: can't resolve 'google.com'
nslookup: can't resolve 'google.com'
Server:    10.0.0.10
Address 1: 10.0.0.10

waiting for DNS resolution

jessfraz · 2018-06-15T20:20:29Z

ah i will spin up and test

jessfraz · 2018-06-20T02:46:38Z

it passed \o/

Signed-off-by: Jess Frazelle <[email protected]>

jackfrancis · 2018-06-25T17:50:54Z

/lgtm

Thanks @jessfraz!

acs-bot · 2018-06-25T17:50:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jessfraz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ghost assigned jessfraz May 15, 2018

ghost added the in progress label May 15, 2018

jessfraz force-pushed the remove-docker branch 2 times, most recently from 246358c to 802ab7a Compare May 15, 2018 20:48

jackfrancis force-pushed the remove-docker branch from 802ab7a to 234cf4c Compare May 18, 2018 19:18

ghost assigned jackfrancis May 18, 2018

acs-bot added the size/L label May 18, 2018

jackfrancis reviewed May 18, 2018

View reviewed changes

dividinglimits reviewed May 19, 2018

View reviewed changes

jessfraz force-pushed the remove-docker branch from 234cf4c to 44df46f Compare May 21, 2018 23:47

jessfraz force-pushed the remove-docker branch 3 times, most recently from 91fbd17 to 4503665 Compare May 22, 2018 01:02

jessfraz force-pushed the remove-docker branch 4 times, most recently from 8a35f22 to ae2a72b Compare June 12, 2018 15:55

jessfraz force-pushed the remove-docker branch from ae2a72b to d2a5a91 Compare June 12, 2018 17:52

jessfraz force-pushed the remove-docker branch from d2a5a91 to 55df327 Compare June 12, 2018 19:39

jackfrancis force-pushed the remove-docker branch from 55df327 to 648b747 Compare June 15, 2018 20:01

jessfraz mentioned this pull request Jun 18, 2018

remove docker dependency from hyperkube extract #3296

Merged

jessfraz force-pushed the remove-docker branch 7 times, most recently from 977bf3b to 15f5e1c Compare June 19, 2018 23:19

cleanup unused e2e configs since these are sent as parameters in jenkins

382bfdd

Signed-off-by: Jess Frazelle <[email protected]>

jackfrancis force-pushed the remove-docker branch from 15f5e1c to 576d825 Compare June 22, 2018 19:19

add requiresDocker parameter

4068ddd

Signed-off-by: Jess Frazelle <[email protected]>

jessfraz force-pushed the remove-docker branch from 576d825 to 4068ddd Compare June 25, 2018 17:14

acs-bot added the lgtm label Jun 25, 2018

acs-bot added the approved label Jun 25, 2018

jackfrancis merged commit fcbf0b4 into Azure:master Jun 25, 2018

ghost removed the in progress label Jun 25, 2018

jessfraz deleted the remove-docker branch June 25, 2018 17:55

UnwashedMeme mentioned this pull request Jul 2, 2018

net.ipv4.ip_forward not set #3394

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove docker #2973

Remove docker #2973

jessfraz commented May 15, 2018

jessfraz commented May 15, 2018

codecov bot commented May 18, 2018 •

edited

Loading

jackfrancis commented May 18, 2018

jackfrancis May 18, 2018

jackfrancis May 18, 2018

jackfrancis commented May 18, 2018

dividinglimits May 19, 2018

jessfraz commented May 21, 2018

jessfraz commented May 21, 2018 •

edited

Loading

jessfraz commented May 22, 2018

jackfrancis commented May 22, 2018

jessfraz commented Jun 12, 2018

jackfrancis commented Jun 12, 2018

jessfraz commented Jun 12, 2018 via email

jackfrancis commented Jun 15, 2018

jackfrancis commented Jun 15, 2018

jessfraz commented Jun 15, 2018

jessfraz commented Jun 20, 2018

jackfrancis commented Jun 25, 2018

acs-bot commented Jun 25, 2018

Remove docker #2973

Remove docker #2973

Conversation

jessfraz commented May 15, 2018

jessfraz commented May 15, 2018

codecov bot commented May 18, 2018 • edited Loading

Codecov Report

jackfrancis commented May 18, 2018

jackfrancis May 18, 2018

Choose a reason for hiding this comment

jackfrancis May 18, 2018

Choose a reason for hiding this comment

jackfrancis commented May 18, 2018

dividinglimits May 19, 2018

Choose a reason for hiding this comment

jessfraz commented May 21, 2018

jessfraz commented May 21, 2018 • edited Loading

jessfraz commented May 22, 2018

jackfrancis commented May 22, 2018

jessfraz commented Jun 12, 2018

jackfrancis commented Jun 12, 2018

jessfraz commented Jun 12, 2018 via email

jackfrancis commented Jun 15, 2018

jackfrancis commented Jun 15, 2018

jessfraz commented Jun 15, 2018

jessfraz commented Jun 20, 2018

jackfrancis commented Jun 25, 2018

acs-bot commented Jun 25, 2018

codecov bot commented May 18, 2018 •

edited

Loading

jessfraz commented May 21, 2018 •

edited

Loading