This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fix Windows sku + offer + publisher k8s and swarm variables #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
CecileRobertMichon
changed the title
| "agentWindowsSku": "2016-Datacenter-with-Containers", | ||
| "agentWindowsPublisher": "[parameters('agentWindowsPublisher')]", | ||
| "agentWindowsOffer": "[parameters('agentWindowsOffer')]", | ||
| "agentWindowsSku": "[parameters('agentWindowsSku')]", |
There was a problem hiding this comment.
This is changing the SKU default from 2016-Datacenter-with-Containers to Datacenter-Core-1709-with-Containers-smalldisk and the offer default from WindowsServer to WindowsServerSemiAnnual, consistent with #2664 FYI cc: @JiangtianLi
CecileRobertMichon
changed the title
added 2 commits
May 15, 2018 10:15
CecileRobertMichon
force-pushed
the
agent-win-sku
branch
from
45a52ae to
5cfe59b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2955 +/- ##
=========================================
Coverage ? 50.78%
=========================================
Files ? 97
Lines ? 14703
Branches ? 0
=========================================
Hits ? 7467
Misses ? 6539
Partials ? 697Continue to review full report at Codecov.
|
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: PR #2664 allowed specifying a custom sku + offer + publisher for DCOS, this PR is extending that to k8s and swarm as well.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2953Special notes for your reviewer:
If applicable:
Release note: