Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

change the docker service sequence #2865

Merged
merged 1 commit into from
May 5, 2018
Merged

Conversation

dmitsh
Copy link

@dmitsh dmitsh commented May 4, 2018

Restarting docker after docker.socket has been started creates an intermittent issue in docker.socket - port already in use.
Changing the starting sequence to docker.socket.service -> docker.sservice

@ghost ghost assigned dmitsh May 4, 2018
@ghost ghost added the in progress label May 4, 2018
Copy link

@soccerGB soccerGB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 5, 2018

Codecov Report

Merging #2865 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2865      +/-   ##
=========================================
+ Coverage   49.19%   49.2%   +0.01%     
=========================================
  Files          91      91              
  Lines       13835   13835              
=========================================
+ Hits         6806    6808       +2     
+ Misses       6397    6396       -1     
+ Partials      632     631       -1
Impacted Files Coverage Δ
pkg/operations/kubernetesupgrade/upgrader.go 57.5% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbfabdb...dd23ab0. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants