Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

simplified DCOS bootstrap deployment #2864

Merged
merged 2 commits into from
May 4, 2018
Merged

Conversation

dmitsh
Copy link

@dmitsh dmitsh commented May 4, 2018

  • simplified bootstrap deployment
  • fixed docker.socket issue on master/agent nodes

- fixed docker.socket issue on master/agent nodes
@ghost ghost assigned dmitsh May 4, 2018
@ghost ghost added the in progress label May 4, 2018
yakman2020
yakman2020 previously approved these changes May 4, 2018
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #2864 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2864      +/-   ##
=========================================
+ Coverage   49.25%   49.3%   +0.04%     
=========================================
  Files          91      91              
  Lines       13823   13803      -20     
=========================================
- Hits         6808    6805       -3     
+ Misses       6384    6368      -16     
+ Partials      631     630       -1
Impacted Files Coverage Δ
pkg/api/convertertoapi.go 55.73% <0%> (-0.06%) ⬇️
pkg/api/types.go 27.27% <0%> (ø) ⬆️
pkg/api/vlabs/types.go 18.57% <0%> (ø) ⬆️
pkg/openshift/certgen/config.go 40% <0%> (ø) ⬆️
pkg/armhelpers/graph.go 0% <0%> (ø) ⬆️
pkg/api/converterfromapi.go 9.73% <0%> (+0.01%) ⬆️
pkg/acsengine/defaults.go 73.78% <0%> (+0.14%) ⬆️
cmd/deploy.go 25.58% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5c9a3...f8f87ea. Read the comment docs.

@dmitsh dmitsh changed the title DCOS bootstrap deployment improvements simplified DCOS bootstrap deployment May 4, 2018
@soccerGB
Copy link

soccerGB commented May 4, 2018

The changes look good to me

Copy link

@soccerGB soccerGB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit 9652865 into Azure:master May 4, 2018
@ghost ghost removed the in progress label May 4, 2018
@dmitsh dmitsh deleted the ds-dcos-bstrap branch May 7, 2018 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants