Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

remove route table when using cilium CNI #2834

Merged
merged 2 commits into from
May 2, 2018

Conversation

khenidak
Copy link
Contributor

@khenidak khenidak commented May 1, 2018

What this PR does / why we need it:
fixes #2829 -- no route table + disable route controller when using cilium

WIP note: this PR is still under test.

@khenidak khenidak changed the title [WIP] remove route table when using cilium remove route table when using cilium CNI May 2, 2018
@khenidak
Copy link
Contributor Author

khenidak commented May 2, 2018

@jackfrancis @CecileRobertMichon ready for review..

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #2834 into master will increase coverage by 0.2%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2834     +/-   ##
=========================================
+ Coverage   46.73%   46.93%   +0.2%     
=========================================
  Files          86       86             
  Lines       12862    12822     -40     
=========================================
+ Hits         6011     6018      +7     
+ Misses       6294     6249     -45     
+ Partials      557      555      -2
Impacted Files Coverage Δ
pkg/api/types.go 27.27% <0%> (-1.62%) ⬇️
pkg/acsengine/defaults-controller-manager.go 100% <100%> (ø) ⬆️
pkg/acsengine/engine.go 62.91% <100%> (+0.05%) ⬆️
pkg/acsengine/defaults-cloud-controller-manager.go 100% <100%> (ø) ⬆️
pkg/api/vlabs/validate.go 42.93% <0%> (+0.14%) ⬆️
test/e2e/azure/cli.go 4.05% <0%> (+0.75%) ⬆️
pkg/operations/kubernetesupgrade/upgrader.go 57.5% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f304349...ebebd78. Read the comment docs.

@jackfrancis jackfrancis merged commit fe1f77e into Azure:master May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cilium + vmss creates uanessacry route table
2 participants