Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

StorageProfile default is now ManagedDisks #2833

Merged
merged 4 commits into from
May 3, 2018

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented May 1, 2018

What this PR does / why we need it: default to ManagedDisks for storage, i.e. Microsoft.Compute/availabilitySets, instead of StorageAccount, i.e., Microsoft.Storage/storageAccounts

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2799

Special notes for your reviewer: Also rationalized examples/ api models to remove any perception that ManagedDisks is an explicit opt-in feature.

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

StorageProfile default is now ManagedDisks

@ghost ghost assigned jackfrancis May 1, 2018
@ghost ghost added the in progress label May 1, 2018
@jackfrancis
Copy link
Member Author

@khenidak @lachie83 FYI

@codecov
Copy link

codecov bot commented May 1, 2018

Codecov Report

Merging #2833 into master will decrease coverage by 1.71%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2833      +/-   ##
==========================================
- Coverage   48.99%   47.28%   -1.72%     
==========================================
  Files          91       86       -5     
  Lines       13788    12815     -973     
==========================================
- Hits         6755     6059     -696     
+ Misses       6409     6197     -212     
+ Partials      624      559      -65
Impacted Files Coverage Δ
pkg/acsengine/defaults.go 72.25% <100%> (+7.44%) ⬆️
cmd/generate.go 26.43% <0%> (-5.95%) ⬇️
cmd/deploy.go 23.8% <0%> (-1.78%) ⬇️
pkg/api/vlabs/validate.go 42.93% <0%> (-1.57%) ⬇️
pkg/acsengine/engine.go 62.86% <0%> (-1.51%) ⬇️
pkg/operations/kubernetesupgrade/upgrader.go 56.66% <0%> (-0.84%) ⬇️
pkg/api/converterfromagentpoolonlyapi.go 22.08% <0%> (-0.42%) ⬇️
pkg/acsengine/transform/transform.go 59.81% <0%> (-0.19%) ⬇️
pkg/api/common/versions.go 82.02% <0%> (-0.11%) ⬇️
pkg/acsengine/defaults-kubelet.go 93.5% <0%> (-0.09%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9b3f1...81862d8. Read the comment docs.

@jackfrancis jackfrancis force-pushed the managed-disks-default branch from 2964ef6 to 81862d8 Compare May 3, 2018 16:20
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit cd14e01 into Azure:master May 3, 2018
@ghost ghost removed the in progress label May 3, 2018
@jackfrancis jackfrancis deleted the managed-disks-default branch May 3, 2018 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ManagedDisk default
2 participants