This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Remove storageAccounts from K8s VMSS #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #2830 +/- ##
==========================================
- Coverage 46.94% 46.93% -0.01%
==========================================
Files 86 86
Lines 12809 12811 +2
==========================================
Hits 6013 6013
- Misses 6241 6242 +1
- Partials 555 556 +1
Continue to review full report at Codecov.
|
|
@sozercan Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Storage accounts doesn't allow attaching AzureDisks. This PR removes storage accounts from VMSS and adds validation for it.
/cc @feiskyer
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Fixes #2824