-
Notifications
You must be signed in to change notification settings - Fork 558
Conversation
@JiangtianLi @tamilmani1989 @sharmasushant Could you please review? Thanks! |
@saiyan86 It is hard to see the diff, possibly due to line ending? Can you adjust it? |
@JiangtianLi append @saiyan86 I've tagged this PR as do-not-merge. Please @ me when v1.0.4 is released and I'll move this effort forward. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report
@@ Coverage Diff @@
## master #2822 +/- ##
=======================================
Coverage 46.94% 46.94%
=======================================
Files 86 86
Lines 12809 12809
=======================================
Hits 6013 6013
Misses 6241 6241
Partials 555 555 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2822 +/- ##
======================================
Coverage 49.3% 49.3%
======================================
Files 91 91
Lines 13803 13803
======================================
Hits 6805 6805
Misses 6368 6368
Partials 630 630
Continue to review full report at Codecov.
|
@JiangtianLi Sorry for the hassle, but the line ending seems to be fine with me. |
@saiyan86 no problem. what link do you use to see the diff? Just curious what have changed recently. I didn't remember to append |
@JiangtianLi I added a Set-AzureCNIConfig() function and calls it in Set-NetworkConfig |
@saiyan86 Sorry I didn't mean what you have changed. I wonder if you can view the diff without |
@JiangtianLi I can view the diff in my local VSCode. But for github, I have to add |
@JiangtianLi @jackfrancis We just released Azure CNI v1.0.4. Could you please pull the binaries to acs-engine mirror and merge this PR? Thanks!! |
@saiyan86 I updated |
@saiyan86 Is there any additional Windows work that needs to happen for this PR, or should we assume successful E2E deployments indicate validation of the changes? |
If you can point me to a build (circleCI?) I can do a quick deploy |
862fc32
to
0c04344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it:
This PR enables kubernetes DNS and endpoint policies in Azure CNI.
Special notes for your reviewer:
This PR requires Azure CNI v1.0.4. Please do not merge until Azure CNI v1.0.4 is released.
Required Azure CNI PR: Azure/azure-container-networking#127