Refine Istio example #2819
Refine Istio example #2819
Conversation
|
LGTM, with some minor comments. I talked with @billpratt during sync week last week where their focus was this topic area. It seems 0.7.0 Istio and/or updates to K8s has resolved some problems I encountered at the time I submitted the first example - in particular, the previous need to specify the |
| "orchestratorRelease": "1.9", | ||
| "kubernetesConfig": { | ||
| "apiServerConfig": { | ||
| "--admission-control": "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota,DenyEscalatingExec,AlwaysPullImages,ValidatingAdmissionWebhook,ResourceQuota", |
There was a problem hiding this comment.
I encountered problems with some of the bookinfo examples deploying properly when you use DenyEscalatingExec and AlwaysPullImages. Did you test this out? If it causes errors, it might be good to at least mention this so people can consider to enable them or not.
There was a problem hiding this comment.
Yes, I had no problems leaving these enabled.
| ### Installation | ||
|
|
||
| #### Create Azure Resources | ||
|
|
There was a problem hiding this comment.
IMO, I would leave this stuff for the main walkthrough so it doesn't have to be maintained.
There was a problem hiding this comment.
@wesyao Since you wrote these changes, what are your thoughts?
There was a problem hiding this comment.
@jackfrancis @dtzar @billpratt Sorry about the delay, I was waiting for others to chime in. I think it would be good to have now and we can remove this when it is repetitive? What do you guys think?
|
@jackfrancis some checks seem to be stuck? |
|
@billpratt I was waiting on a response from @wesyao, but let's proceed, we can address @dtzar's comment in a follow-up PR if there's agreement. And btw because this is just markdown + json maintenance we don't have to run E2E. |
Addressing #2569