Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Update README.md #2797

Merged
merged 4 commits into from
May 3, 2018
Merged

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Apr 27, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@ghost ghost added the in progress label Apr 27, 2018
@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

Merging #2797 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2797      +/-   ##
==========================================
- Coverage   46.93%   46.82%   -0.12%     
==========================================
  Files          86       86              
  Lines       12786    12774      -12     
==========================================
- Hits         6001     5981      -20     
- Misses       6231     6249      +18     
+ Partials      554      544      -10
Impacted Files Coverage Δ
pkg/helpers/helpers.go 9.09% <0%> (-5.2%) ⬇️
pkg/api/vlabs/validate.go 40.73% <0%> (-2.5%) ⬇️
pkg/api/convertertoagentpoolonlyapi.go 28.11% <0%> (-0.37%) ⬇️
pkg/acsengine/engine.go 62.72% <0%> (-0.11%) ⬇️
cmd/upgrade.go 0% <0%> (ø) ⬆️
cmd/scale.go 0% <0%> (ø) ⬆️
pkg/api/convertertoapi.go 56.62% <0%> (+0.1%) ⬆️
cmd/deploy.go 23.95% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b456302...be0d14f. Read the comment docs.

@CecileRobertMichon CecileRobertMichon changed the title Update README.md [WIP] Update README.md Apr 27, 2018
* Custom VNET
* Extensions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackfrancis any acs-engine features you'd like to see mentioned here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now

@CecileRobertMichon CecileRobertMichon changed the title [WIP] Update README.md Update README.md May 3, 2018
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CecileRobertMichon CecileRobertMichon merged commit c87358b into Azure:master May 3, 2018
@ghost ghost removed the in progress label May 3, 2018
@CecileRobertMichon CecileRobertMichon deleted the readme branch June 6, 2018 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants