-
Notifications
You must be signed in to change notification settings - Fork 558
add node labels arg to windows setup script #2770
add node labels arg to windows setup script #2770
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2770 +/- ##
==========================================
- Coverage 46.82% 46.81% -0.01%
==========================================
Files 86 86
Lines 12774 12776 +2
==========================================
Hits 5981 5981
- Misses 6249 6250 +1
- Partials 544 545 +1
Continue to review full report at Codecov.
|
@JamesEarle Thanks for fixing this. It is hard to see the diff, possibly due to line endings. Can you fix it? |
@JiangtianLi my changes are the additions from line 294-299, adding "--node-labels `$KUBELET_NODE_LABELS" to the args list. I haven't completed this though, as I'm not sure how to access the func Do you know if I can do this? Working with Jack on it. |
@JiangtianLi the changes should be easier to see in the most recent commit. |
@JamesEarle You can take a look at how windowsTelemetryGUID is passed to ps1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jackfrancis @JiangtianLi
Addresses #563
Adding KUBELET_NODE_LABELS to ArgList, need to figure out how to access the GetAgentKubernetesLabels function from here, if possible