This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
normalizeazureregion added in scale, upgrade, and deploy #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
cmd/deploy.go
Outdated
| @@ -83,6 +84,11 @@ func newDeployCmd() *cobra.Command { | |||
| return deployCmd | |||
| } | |||
|
|
|||
| // NormalizeAzureRegion returns a normalized Azure region with whilte spaces removed and converted to lower case | |||
There was a problem hiding this comment.
typo in the comment whilte --> white
There was a problem hiding this comment.
We could add this function to https://github.com/Azure/acs-engine/blob/master/pkg/helpers/helpers.go and re-use it here and in pkg/api
Codecov Report
@@ Coverage Diff @@
## master #2764 +/- ##
=========================================
- Coverage 46.82% 46.8% -0.02%
=========================================
Files 86 86
Lines 12773 12778 +5
=========================================
Hits 5981 5981
- Misses 6248 6253 +5
Partials 544 544
Continue to review full report at Codecov.
|
| @@ -9,3 +9,32 @@ func TestPointerToBool(t *testing.T) { | |||
| t.Fatalf("expected PointerToBool(true) to return *true, instead returned %#v", ret) | |||
| } | |||
| } | |||
|
|
|||
| func TestIsRegionNormalized(t *testing.T) { | |||
pkg/helpers/helpers_test.go
Outdated
| for _, c := range cases { | ||
| result := NormalizeAzureRegion(c.input) | ||
| if c.expectedResult != result { | ||
| t.Fatalf("NormalizeAzureRegion returned unexpected result: expected %t but got %t", c.expectedResult, result) |
There was a problem hiding this comment.
%s instead of %t here since we're printing string types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: It solves the issue outlined in: #2258
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2258Special notes for your reviewer:
If applicable:
Release note: