Use latest patch of DefaultKubernetesRelease as default k8s version #2654
Conversation
ghost
assigned 
|
Should we instead prefer a release channel (i.e., 1.8) and then just make the default version the latest patch release in that channel? |
|
Yes I think that makes sense. The only reason I see that would prevent us from doing that is baking newly released k8s minor versions in acs-engine before we make them default. For example, when k8s 1.8.12 comes out, we add support for it right away but we only promote it to the default version after it has been passing our 1.8 tests for a while. What do you think? |
|
I think we defer to k8s to bake basic stability into the most current release. But open to doing anything reasonable that is automateable. |
|
Ok agreed, I'll modify this PR to implement a default release instead of a default version |
CecileRobertMichon
changed the title
| } | ||
| return GetAllSupportedKubernetesVersions(), string(KubernetesDefaultVersion) |
There was a problem hiding this comment.
Any reason why a string conversion was necessary here? I removed it but let me know if I'm missing something @jackfrancis
There was a problem hiding this comment.
not a sane one that I can think of, nope!
What this PR does / why we need it: Update k8s default version from 1.8.9 to 1.8.11
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: