This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
add Merge function for v20180331 to guard update scenario #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
rjtsdl
force-pushed
the
jiren-addvalidationforrbac
branch
from
2faca07 to
1410195
Compare
rjtsdl
commented
Apr 10, 2018
| version string, | ||
| validate, isUpdate bool, | ||
| defaultKubernetesVersion string, | ||
| existingContainerService *ContainerService) (*ContainerService, bool, error) { |
There was a problem hiding this comment.
Need to update RP when vendor this change. Just a simple change.
rjtsdl
force-pushed
the
jiren-addvalidationforrbac
branch
from
1410195 to
92229f6
Compare
|
|
|
@weinong can we do in a different PR? Synced, I will just add dnsPrefix merge in this PR as well. |
weinong
approved these changes
Apr 11, 2018
jackfrancis
pushed a commit
that referenced
this pull request
Apr 11, 2018
* add Merge function for v20180331 to guard update scenario * add merge for properties.dnsPrefix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2646Special notes for your reviewer:
following #2647, this PR is to add validation on update scenario. So we catch all the cases when enableRBAC could possibly be changed. And return as error
If applicable:
Release note: