This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
remove deprecated etcd-quorum-read flag from apiserver #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
seanknox
commented
Apr 7, 2018
| |"--etcd-certfile"|"/etc/kubernetes/certs/etcdclient.crt"| | ||
| |"--etcd-keyfile"|"/etc/kubernetes/certs/etcdclient.key"| | ||
| |"--etcd-servers"|*calculated value that represents etcd servers*| | ||
| |"--etcd-quorum-read"|"true"| |
There was a problem hiding this comment.
My editor removed a lot of erroneous whitespace apparently, but this is the only line that actually changed (was removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The apiserver flag `--etcd-quorum-read was deprecated in Kubernetes v1.9 and removed in v1.10 because setting it to false causes bugs in controllers because of stale reads. It is true by default in from >= v1.8 upward until v1.10, where it was removed entirely.
Note: starting in v1.7 users had this option, and had to explicitly disable etcd quorum reads if desired, so this shouldn't affect older acs-engine clusters nor should it affect upgrades. This is effectively a non-issue since we use etcd3 by default which is much more performant with reads.
More info:
If applicable: