This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Add support for k8s v1.8.11 #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
As per v1.8.11 release notes, rev'd the kube-dns version |
jackfrancis
commented
Apr 5, 2018
| versions := make([]string, 0, len(AllKubernetesWindowsSupportedVersions)) | ||
| for k := range AllKubernetesWindowsSupportedVersions { | ||
| versions = append(versions, k) | ||
| var versions []string |
There was a problem hiding this comment.
This fixes a bug,as prior it was returning all versions regardless of the bool value.
(admittedly AllKubernetesWindowsSupportedVersions isn't the best name for a hash table that includes explicitly not supported versions)
GetAllSupportedKubernetesVersions() should not return if a version is disabled
jackfrancis
commented
Apr 5, 2018
| for k := range AllKubernetesSupportedVersions { | ||
| versions = append(versions, k) | ||
| var versions []string | ||
| for ver, supported := range AllKubernetesSupportedVersions { |
jackfrancis
commented
Apr 5, 2018
| t.Errorf( | ||
| "should not error on valid Windows version: %v", err, | ||
| ) | ||
| for _, version := range common.GetAllSupportedKubernetesVersionsWindows() { |
There was a problem hiding this comment.
using a bunch of static versions was not maintainable, actually enumerating through known supported list now to test validation
| } | ||
|
|
||
| p = getK8sDefaultProperties(false) | ||
| p.OrchestratorProfile.OrchestratorVersion = "1.9.7" |
jackfrancis
added a commit
that referenced
this pull request
Apr 6, 2018
* add support for k8s v1.8.11, rationalize version tests * update kube-dns to v1.14.9 as per release notes * should only return enabled versions GetAllSupportedKubernetesVersions() should not return if a version is disabled # Conflicts: # pkg/api/vlabs/validate_test.go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Kubernetes v1.8.11:
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.8.md#v1811
Also rationalize version tests
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: